Skip to content

[Security] Expressions: is_fully_authenticated() vs IS_AUTHENTICATED_FULLY #10688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cristi-contiu opened this issue Nov 20, 2018 · 0 comments
Closed
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Milestone

Comments

@cristi-contiu
Copy link
Contributor

cristi-contiu commented Nov 20, 2018

In the Security / Expressions docs the differences between the is_remember_me() expression function and the IS_AUTHENTICATED_REMEMBERED attribute are clearly explained in the infobox.

They also mention that is_fully_authenticated is "Similar, but not equal to IS_AUTHENTICATED_FULLY, see below." but fail to provide such a distinction. Moreover, the explanation for is_fully_authenticated seems to be very similar the one for IS_AUTHENTICATED_FULLY - maybe I am missing some nuances:

only returns true if the user has actually logged in during this session (i.e. is full-fledged)

Users who are logged in only because of a "remember me cookie" will have IS_AUTHENTICATED_REMEMBERED but will not have IS_AUTHENTICATED_FULLY

If they are identical, we should change the explanation in the Security / Expressions docs to say : "Equal to using IS_AUTHENTICATED_FULLY with the isGranted() function."

If they are not identical, we should explain how are they different.

Thanks!

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Sep 6, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Development

No branches or pull requests

3 participants