Skip to content

Tweaked the explanation about the is_fully_authenticated() function #12280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

Tweaked the explanation about the is_fully_authenticated() function #12280

merged 1 commit into from
Sep 19, 2019

Conversation

javiereguiluz
Copy link
Member

Fixes #10688.

@javiereguiluz javiereguiluz added this to the 3.4 milestone Sep 6, 2019
wouterj
wouterj approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% correct! Both the expression function and authorization attribute use TrustResolver#isFullyFledged() so are indeed equal.

@javiereguiluz
Copy link
Member Author

Wouter, thanks for your review!

javiereguiluz added a commit that referenced this pull request Sep 19, 2019
@javiereguiluz
minor #12280 Tweaked the explanation about the is_fully_authenticated…
6a5fa12 
…() function (javiereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Tweaked the explanation about the is_fully_authenticated() function

Fixes #10688.

Commits
-------

0c121a1 Tweaked the explanation about the is_fully_authenticated() function
@javiereguiluz javiereguiluz merged commit 0c121a1 into symfony:3.4 Sep 19, 2019
@javiereguiluz javiereguiluz deleted the fix_10688 branch September 19, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @wouterj @carsonbot