Skip to content

[Validator] Inline literals for constraint option names? #15134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
henry2778 opened this issue Mar 21, 2021 · 1 comment
Closed

[Validator] Inline literals for constraint option names? #15134

henry2778 opened this issue Mar 21, 2021 · 1 comment
Labels
Validator

Comments

@henry2778
Copy link
Contributor

henry2778 commented Mar 21, 2021 •
edited
Loading

Hello. I noticed that the option names in constraint option lists sometimes go with backticks (which is the 'inline literal' thing) and sometimes without. The question is what is the correct way to describe them? I would like to fix it and to ask for the opinions first. It is hard to notice the difference on when you read the docs on the site, but still. WDYT? Thanks! :)

image
@xabbuh
Copy link
Member

xabbuh commented Mar 26, 2021

In the form type options reference we always use literals. I think we should do the same here.

@henry2778 henry2778 mentioned this issue Mar 27, 2021
Merged
javiereguiluz added a commit that referenced this issue Mar 27, 2021
@javiereguiluz
minor #15159 [Validator] Add missing backticks for constraint option …
3110a67 
…names (henry2778)

This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Validator] Add missing backticks for constraint option names

Adding some missing backticks for constraint option names. Thanks! :)
Issue: #15134

Commits
-------

1e6d130 [Validator] Add missing backticks for constraint option names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xabbuh @henry2778 @carsonbot