Update recommended password encoder to "auto" #11767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
security_encoder
branch
from
1bdd1d8 to
5ca528f
Compare
wouterj
reviewed
Aug 18, 2019
| @@ -280,12 +280,12 @@ password) so you don't have to deal with it. | |||
|
|
|||
| .. _reference-security-bcrypt: | |||
|
|
|||
| Using the BCrypt Password Encoder | |||
| Using the "auto" Password Encoder | |||
There was a problem hiding this comment.
Imho, we should keep this section, it is just talking about the BCrypt algorithm, and instead add a new section for the auto password encoder.
There was a problem hiding this comment.
The bcrypt encoder has been deprecated though. Also technically speaking auto is not an encoder, it's only a possible value for the algorithm config option which saves from having to choose between native and sodium. So I'm not fond of documenting it this way neither.
chalasr
reviewed
Aug 18, 2019
javiereguiluz
force-pushed
the
security_encoder
branch
from
3e25cf2 to
fb21211
Compare
javiereguiluz
added a commit
that referenced
this pull request
Sep 24, 2019
This PR was squashed before being merged into the 4.3 branch (closes #11767). Discussion ---------- Update recommended password encoder to "auto" |Q |A | |--- |---| |Branch |4.3| |Bug fix? |no | |New feature? |no | |BC breaks? |no | |Deprecations?|no | |Tests pass? |yes| |Fixed tickets|n/a| |License |MIT| See https://github.com/symfony/symfony/blob/v4.3.0/UPGRADE-4.3.md#securitybundle. Commits ------- fb21211 Update recommended password encoder to \"auto\"
|
Javier, thanks for this contribution! It's merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/symfony/symfony/blob/v4.3.0/UPGRADE-4.3.md#securitybundle.