-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Revamped the routing documentation #12114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is now ready for review. You can ignore syntax issues and broken/missing references because I'll fix all that very soon. Please, focus on contents, typos, etc. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. With less tiny chapters, we can make this one document much more fluid and consistent. I've suggested enough moving around of sections that I'll stop reviewing now, and can review more later.
f754ebd
to
1f8acec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick review of the first half of the article. Looks like a great job so far! Thanks a lot for the time you've put into this!
I'm not so sure about most of my comments (didn't digg into it very deeply), so feel free to reject them 😃
94ea2e5
to
1268ba7
Compare
This PR was squashed before being merged into the 4.3 branch (closes #12114). Discussion ---------- Revamped the routing documentation The Symfony Docs team has decided to reorganize all the routing articles and create a single reference article explaining all the common routing features. This PR merges several small files into the main `/routing.rst` article and I'll merge other small articles very soon. Meanwhile you can start reviewing these changes. Thank you! Commits ------- 1268ba7 Revamped the routing documentation
The Symfony Docs team has decided to reorganize all the routing articles and create a single reference article explaining all the common routing features.
This PR merges several small files into the main
/routing.rst
article and I'll merge other small articles very soon. Meanwhile you can start reviewing these changes. Thank you!