Fix path #12137
Merged
Fix path #12137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
I'm not sure about this ... as the previous paragraph says:
Unlike the other session options, ``cache_limiter`` is set as a regular
:ref:`container parameter <configuration-parameters>`:
Is it common to add services: and parameters: inside config/packages/*.yaml instead of config/services.yaml ?
I thought the same when doing this change... will change then |
javiereguiluz
approved these changes
Aug 12, 2019
|
@OskarStark this is an edge-case ... so I'd say it's better to keep it in the services file instead of the specific package config. |
OskarStark
added a commit
that referenced
this pull request
Aug 12, 2019
This PR was merged into the 4.3 branch. Discussion ---------- Fix path <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 7c1551a Fix path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.