Skip to content

Avoid assuming things are simple #12227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michellesanver
Copy link
Contributor

There are some places in this doc that used the words "simple" or "simply". We should avoid using these terms.

See: https://github.com/symfony/diversity/issues/9

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, combining "simple" with "inescapably" is really wrong 😕 . Let's get this merged

@OskarStark OskarStark changed the base branch from master to 3.4 August 22, 2019 13:13
@OskarStark OskarStark changed the base branch from 3.4 to master August 22, 2019 13:13
@OskarStark OskarStark added this to the 3.4 milestone Aug 22, 2019
@OskarStark OskarStark changed the base branch from master to 3.4 August 22, 2019 13:15
@OskarStark OskarStark force-pushed the remove-phrasing-things-as-simple branch from 7c44332 to 8ab99e8 Compare August 22, 2019 13:15
@OskarStark
Copy link
Contributor

Thank you Michelle.

OskarStark added a commit that referenced this pull request Aug 22, 2019
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #12227).

Discussion
----------

Avoid assuming things are simple

There are some places in this doc that used the words "simple" or "simply". We should avoid using these terms.

See: symfony/diversity#9

Commits
-------

8ab99e8 Avoid assuming things are simple
@OskarStark OskarStark merged commit 8ab99e8 into symfony:3.4 Aug 22, 2019
@michellesanver michellesanver deleted the remove-phrasing-things-as-simple branch August 22, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants