Skip to content

[Security][Testing] Moved a performance tip to the main performance article #14864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member

I think it's better to show this in the main performance article ... but this is just a proposal, so we can close if you disagree. Thanks!

@javiereguiluz javiereguiluz added this to the 4.4 milestone Jan 21, 2021
@carsonbot carsonbot changed the title Moved a performance tip to the main performance article [Security][Testing] Moved a performance tip to the main performance article Jan 21, 2021
@wouterj
Copy link
Member

wouterj commented Jan 21, 2021

I agree that it needs a better place than the subguide note it is now, but I don't think the performance guide is the best place. I think moving it somewhere in the top-level testing article is probably the best. If you agree, I'll take it into account in #14731

encoders:
# Use your user class name here
App\Entity\User:
algorithm: auto # This should be the same value as in config/packages/security.yaml
Copy link
Contributor

@OskarStark OskarStark Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not proposing plaintext here, like done in @fabpot 's tweet? 🧐

@javiereguiluz
Copy link
Member Author

@wouterj I think the best place would be a single reference article about passwords. We're missing that article and it would explain everything about that topic (the same we do for example in the reference article about CSRF, which explains everything about that).

@javiereguiluz
Copy link
Member Author

Let's close this to include it as part of the testing rewriting that Wouter is working on. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants