Add a better example of the dangers of XSS attacks #19804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For 5.4? |
xabbuh
reviewed
Apr 19, 2024
| * Preventing security attacks based on XSS or other technologies relying on | ||
| execution of malicious code on the visitors browsers; | ||
| * Preventing security attacks based on :ref:`XSS <xss-attacks>` or other technologies | ||
| relying on execution of malicious code on the visitors browsers; |
There was a problem hiding this comment.
Suggested change
| relying on execution of malicious code on the visitors browsers; | |
| relying on the execution of malicious code on the visitors browsers; |
There was a problem hiding this comment.
I'll do this fix when upmerging #19805.
|
Good idea to do it in 5.4. I tried to rebase but I failed, so I'm recreating the PR in #19805. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common problem with docs about XSS attacks is that they always show a harmless example that just displays a JavaScript popup.
I propose to show a better and most dangerous example ... and also link all references to XSS attacks in the docs to this new example.