Skip to content

Fix typo preventing link to be parsed #20334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

cirdan
Copy link
Contributor

@cirdan cirdan commented Oct 16, 2024

The documentation website displays a commit hash, instead of the link to the tags section.
https://symfony.com/doc/6.4/service_container/service_decoration.html

The documentation website displays a commit hash, instead of the link to the tags section
@carsonbot carsonbot added this to the 6.4 milestone Oct 16, 2024
@@ -225,7 +225,7 @@ automatically changed to ``'.inner'``):

.. note::

All custom :ref:`service tags </service_container/tags>`_ from the decorated
All custom :ref:`service tags </service_container/tags>` from the decorated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All custom :ref:`service tags </service_container/tags>` from the decorated
All custom :doc:`service tags </service_container/tags>` from the decorated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was needed too. I did this while merging. Thanks!

@javiereguiluz javiereguiluz merged commit ac4fde2 into symfony:6.4 Oct 16, 2024
3 checks passed
@javiereguiluz
Copy link
Member

Good catch! Thanks Sylvain.

@cirdan cirdan deleted the doc-fix-decoration branch October 17, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants