Skip to content

Added translations directory to file tree #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2017
Merged

Conversation

fridde
Copy link
Contributor

@fridde fridde commented Nov 18, 2017

The description below the directory tree references the translation directory, which is missing in the tree.

@weaverryan
Copy link
Member

@javiereguiluz Since symfony/recipes#253 was merged, this is valid, correct?

I'm not sure if it should be included, but it seems a little bit safer to show more directories here than less (so we can answer the question: "Hey, where do my translations go?")

@javiereguiluz
Copy link
Member

Yes, this is correct. Should we add the remaining missing dirs?

assets/
bin/
  console
tests/
var/

@weaverryan
Copy link
Member

Good idea! I just added the other dirs

@xabbuh xabbuh added this to the 4.0 milestone Nov 22, 2017
@xabbuh xabbuh changed the base branch from master to 4.0 November 22, 2017 12:22
@xabbuh
Copy link
Member

xabbuh commented Nov 23, 2017

Thank you @fridde.

@xabbuh xabbuh merged commit 4f628d7 into symfony:4.0 Nov 23, 2017
xabbuh added a commit that referenced this pull request Nov 23, 2017
…ryan)

This PR was merged into the 4.0 branch.

Discussion
----------

Added translations directory to file tree

The description below the directory tree references the translation directory, which is missing in the tree.

Commits
-------

4f628d7 adding other dirs
e0fa5cb Update flex.rst
@fridde fridde deleted the patch-1 branch January 10, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants