[Routing] Deprecate annotations in favor of attributes #49358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests are related. I'm looking into those later today. |
stof
reviewed
Feb 13, 2023
src/Symfony/Component/Routing/Tests/Fixtures/TraceableAnnotationClassLoader.php
Outdated
Show resolved
Hide resolved
derrabus
force-pushed
the
deprecate/route-annotations
branch
from
427785e to
0dbcbe0
Compare
derrabus
force-pushed
the
deprecate/route-annotations
branch
from
0dbcbe0 to
7bab4d6
Compare
derrabus
force-pushed
the
deprecate/route-annotations
branch
from
7bab4d6 to
38b3061
Compare
derrabus
force-pushed
the
deprecate/route-annotations
branch
5 times, most recently
from
44c121f to
9737926
Compare
derrabus
force-pushed
the
deprecate/route-annotations
branch
3 times, most recently
from
ec7c82a to
09500a3
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 20, 2023
…ration (derrabus)
This PR was merged into the 6.4 branch.
Discussion
----------
[FrameworkBundle] Deprecate doctrine/annotations integration
| Q | A
| ------------- | ---
| Branch? | 6.4
| Bug fix? | no
| New feature? | yes
| Deprecations? | yes
| Tickets | N/A
| License | MIT
| Doc PR | TODO
This PR deprecates the integration of the doctrine/annotations package in FrameworkBundle. Currently, the integration is enabled by default if `doctrine/annotations` is installed. This PR adds a runtime deprecation if the app does not explicitly disable it by setting:
```php
framework:
annotations: false
```
The plan is to make this the default and only valid option in Symfony 7 and remove that setting entirely in Symfony 8. This change unlocks #49358 and similar PRs that remove support for Doctrine Annotations from components.
Commits
-------
2b3c954 [FrameworkBundle] Deprecate doctrine/annotations integration
derrabus
force-pushed
the
deprecate/route-annotations
branch
from
09500a3 to
680f0cc
Compare
|
PR is ready |
derrabus
force-pushed
the
deprecate/route-annotations
branch
3 times, most recently
from
95a59e5 to
288437f
Compare
|
The failing tests on the high-deps run can be ignored. Those tests will pass as soon as the change hits 7.0. |
derrabus
force-pushed
the
deprecate/route-annotations
branch
from
288437f to
6ce15f2
Compare
|
deps=high failure is related isn't it? |
|
Does it mean that the high-deps tests will fail for all the PRs until the release of 7.0 in November? |
No, they fail until 6.4 has been merged into 7.0. We can do that right after merging this PR. |
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jul 26, 2023
This PR was merged into the 7.0 branch. Discussion ---------- [Routing] Remove Doctrine annotations support | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Follows #49358 | License | MIT | Doc PR | symfony/symfony-docs#18589 Commits ------- 4b10902 [Routing] Remove Doctrine annotations support
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the integration of Doctrine Annotations for the Routing component.
Attributes are the way to go now if we want to annotate controllers with routing information. Existing applications can be migrated easily using Rector.
Thus I believe that keeping support for oldschool Doctrine Annotations is not necessary anymore.
If this PR is accepted, I would work on a follow-up that renames all
Annotation*Loaderclasses because the names of those classes are probably misleading as soon as they support attributes only.