[PhpUnitBridge] Enable configuring mock namespaces with attributes #59384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
Jan 7, 2025
| run: find ./src/Symfony/Bridge/PhpUnit -name '*.php' | grep -v -e /Tests/ -e ForV7 -e ForV8 -e ForV9 -e ConstraintLogicTrait | parallel -j 4 php -l {} | ||
| run: find ./src/Symfony/Bridge/PhpUnit -name '*.php' | grep -v -e /Tests/ -e /Attribute/ -e /Extension/ -e /Metadata/ -e ForV7 -e ForV8 -e ForV9 -e ConstraintLogicTrait | parallel -j 4 php -l {} |
There was a problem hiding this comment.
PhpUnit 10+ is PHP >=8.1, so it should be ok for the extension classes to use PHP >=8 syntax.
HypeMC
commented
Jan 7, 2025
| @@ -33,7 +40,12 @@ public function notify(Finished $event): void | |||
| foreach ($test->metadata() as $metadata) { | |||
| if ($metadata instanceof Group && 'time-sensitive' === $metadata->groupName()) { | |||
| ClockMock::withClockMock(false); | |||
| break; | |||
src/Symfony/Bridge/PhpUnit/Extension/RegisterClockMockSubscriber.php
Outdated
Show resolved
Hide resolved
HypeMC
force-pushed
the
phpunit-bridge-attributes
branch
2 times, most recently
from
3199197 to
54c59f7
Compare
xabbuh
reviewed
Jan 7, 2025
HypeMC
force-pushed
the
phpunit-bridge-attributes
branch
from
54c59f7 to
42cc6d2
Compare
nicolas-grekas
approved these changes
Jan 7, 2025
HypeMC
force-pushed
the
phpunit-bridge-attributes
branch
from
42cc6d2 to
130cc26
Compare
|
Thank you @HypeMC. |
chalasr
added a commit
that referenced
this pull request
Jan 11, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [PhpUnitBridge] Mark `AttributeReader` as internal | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follow-up to #59384 Didn't notice this in my original PR, but it'd make sense for the `AttributeReader` class to be marked as internal. Commits ------- ba073c2 [PhpUnitBridge] Mark `AttributeReader` as internal
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure clock and DNS mock namespaces through attributes, removing the need to add them to
phpunit.xml: