Skip to content

[Toolkit] Fix deprecation Kernel > 7.3 #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented May 6, 2025

Fix

  2x: Since symfony/framework-bundle 7.3: Not setting the "with_constructor_extractor" option explicitly is deprecated because its default value will change in version 8.0.
    2x in DebugKitCommandTest::testShouldBeAbleToDebug from Symfony\UX\Toolkit\Tests\Command

@carsonbot carsonbot added Toolkit Status: Needs Review Needs to be reviewed labels May 6, 2025
@smnandre smnandre requested a review from Kocal May 6, 2025 02:52
@Kocal
Copy link
Member

Kocal commented May 7, 2025

I don't understand why it's failing (https://github.com/symfony/ux/actions/runs/14850628341/job/41693406801?pr=2714), but we now have a lot of:

  1. Symfony\UX\Toolkit\Tests\Command\DebugKitCommandTest::testShouldBeAbleToDebug
    Symfony\Component\Config\Definition\Exception\InvalidConfigurationException: Unrecognized option "with_constructor_extractor" under "framework". Available options are "annotations", "asset_mapper", "assets", "cache", "csrf_protection", "default_locale", "disallow_search_engine_index", "enabled_locales", "error_controller", "esi", "exceptions", "form", "fragments", "handle_all_throwables", "html_sanitizer", "http_cache", "http_client", "http_method_override", "ide", "json_streamer", "lock", "mailer", "messenger", "notifier", "php_errors", "profiler", "property_access", "property_info", "rate_limiter", "remote-event", "request", "router", "scheduler", "secret", "secrets", "semaphore", "serializer", "session", "set_content_language_from_locale", "set_locale_from_accept_language", "ssi", "test", "translator", "trust_x_sendfile_type_header", "trusted_headers", "trusted_hosts", "trusted_proxies", "type_info", "uid", "validation", "web_link", "webhook", "workflows".

@Kocal Kocal added Status: Waiting Feedback Needs feedback from the author Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed Status: Waiting Feedback Needs feedback from the author labels May 7, 2025
@smnandre
Copy link
Member Author

smnandre commented May 7, 2025

omg 🤦

I forgot a level of nesting here

@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels May 7, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels May 7, 2025
@Kocal
Copy link
Member

Kocal commented May 7, 2025

Perfect, thanks \o/

Note, 8.4 checks are failing because symfony/symfony#60365 I think, I will open a PR on Symfony
EDIT: opened at symfony/symfony#60373

@Kocal Kocal force-pushed the deprecation-symfony-73 branch from 22938ba to a88a3e4 Compare May 7, 2025 14:59
@Kocal
Copy link
Member

Kocal commented May 7, 2025

Thank you @smnandre.

@Kocal Kocal merged commit 06b78be into symfony:2.x May 7, 2025
10 checks passed
@Kocal Kocal deleted the deprecation-symfony-73 branch May 7, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer Toolkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants