Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for afterTransform hook #15

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Add support for afterTransform hook #15

merged 3 commits into from
Jan 26, 2022

Conversation

danistefanovic
Copy link
Contributor

@danistefanovic danistefanovic commented Jan 25, 2022 •
edited
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Closes #14

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Jan 25, 2022
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 25, 2022
wooorm
wooorm reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The result is good! I think the code, types, and docs can improve a bit:

@wooorm wooorm changed the title Add options.afterTransform Add support for afterTransform hook Jan 26, 2022
@wooorm wooorm merged commit 57fd68b into syntax-tree:main Jan 26, 2022
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added 💪 phase/solved Post is done 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Jan 26, 2022
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 26, 2022
@wooorm
Copy link
Member

wooorm commented Jan 26, 2022

Thanks Daniel, released!

@danistefanovic
Copy link
Contributor Author

Awesome. Thanks!

@danistefanovic danistefanovic mentioned this pull request Jan 26, 2022
Merged
5 tasks
wooorm pushed a commit to syntax-tree/hast-util-from-dom that referenced this pull request Jan 29, 2022
@danistefanovic
Add support for afterTransform hook
b06f043 
Related-to: syntax-tree/hast-util-to-dom#15.
Closes GH-14.

Reviewed-by: Titus Wormer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add visitor function
2 participants
@danistefanovic @wooorm