chore: do not report on implicitly covered lines #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dont_serialize_21 #48 +/- ##
=====================================================
+ Coverage 59.9% 91.3% +31.39%
=====================================================
Files 14 14
Lines 429 414 -15
=====================================================
+ Hits 257 378 +121
+ Misses 172 36 -136
Continue to review full report at Codecov.
|
iamogbz
commented
Dec 24, 2019
| @@ -9,7 +9,6 @@ semver | |||
| twine | |||
| wheel | |||
| py-githooks | |||
| pytest-cov | |||
There was a problem hiding this comment.
Pytest coverage plugin was not correctly catching line coverage
noahnu
pushed a commit
that referenced
this pull request
Dec 24, 2019
* chore: ignore vscode settings * test: remove non-deterministic test for unhashable set * feat: improve assertion diff #22 fix: compare serialized snapshots, close #21 * wip: define serialize as abstract method * chore: print full diff in verbose mode * chore: don't collect coverage from abstract methods * cr: simplify read raw, success style, toml * wip: add back requirements.txt * test: fix coverage reporting (#48) * chore: do not report on implicitly covered lines * wip: more explicit * wip: all is not what it seems * wip: run coverage without pytest-cov * wip: fix coverage source config * wip: fix coverage source config Co-authored-by: Emmanuel Ogbizi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not count