Improve rate limiting for rare buffer warnings #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use pr_warn_ratelimited() to avoid global ratelimit interference from printk_ratelimit(), which is discouraged in the kernel due to shared state across unrelated callsites. Co-authored-by: Po-Ying Chiu <[email protected]>
|
Hi @jserv, may I ask if this patch looks good to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
pr_warn_ratelimited()to avoid global ratelimit interference fromprintk_ratelimit(), which is discouraged in the kernel due to shared state across unrelated callsites.Reference : sysprog21/simrupt#11