Skip to content

Add Manrope variable font #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 10, 2021
Merged

Add Manrope variable font #118

merged 9 commits into from
Oct 10, 2021

Conversation

Kellegram
Copy link
Contributor

Hopefully this is done correctly. Part of #82

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new directory named "assets" and move file "Manrope_variable.ttf" into it.

@Kellegram
Copy link
Contributor Author

Create a new directory named "assets" and move file "Manrope_variable.ttf" into it.

You want that to be in main? Or do you want the font to eventually end up in "assets" in gh-pages?

@jserv
Copy link
Contributor

jserv commented Sep 29, 2021

Create a new directory named "assets" and move file "Manrope_variable.ttf" into it.
You want that to be in main? Or do you want the font to eventually end up in "assets" in gh-pages?

My intention was to make repository slightly neat. That is, the directory assets makes sense in source tree. However, gh-pages is unrelated.

@Kellegram
Copy link
Contributor Author

Yeah makes sense, just making sure, I will be back home soon and will add it.

@jserv jserv requested a review from fennecJ October 9, 2021 15:26
@Kellegram
Copy link
Contributor Author

Sorry 😅 Thank you for being patient with me, I thought I grasped my head around what's happening in the pipeline but I guess I didn't after all.

@jserv jserv merged commit dbac386 into sysprog21:master Oct 10, 2021
@jserv
Copy link
Contributor

jserv commented Oct 10, 2021

Thank @Kellegram for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants