docs: Update example in chapter 8 to use sudo #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jul 3, 2024
jserv
reviewed
Jul 3, 2024
pao0626
force-pushed
the
command-permission-changes
branch
from
82b7652 to
019ba02
Compare
jserv
requested changes
Jul 3, 2024
pao0626
force-pushed
the
command-permission-changes
branch
from
019ba02 to
d054d61
Compare
|
I actually wrote my initial commit message after carefully reviewing the content from the link you provided (https://cbea.ms/git-commit/), and also referred to https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/ for adding a to the title. However, I couldn't find the best way to express it. I have now rethought and submitted a new commit message. If there are still areas that can be improved, please let me know. |
jserv
requested changes
Jul 3, 2024
Add sudo to commands in Chapter 8 for example module interaction. The "myvariables" in the module are set with 0660 permissions via __ATTR(), preventing direct user access. Options to fix this: 1. Instruct users to use 'sudo' to read/write files. 2. Relax the permission settings to 0666. This commit adopts the sudo method to maintain security constraints.
pao0626
force-pushed
the
command-permission-changes
branch
from
d054d61 to
be16ad6
Compare
|
Thank you for the feedback. I initially referred to #169 for improvements. I have now rethought the title to include more informative content. |
|
Thank @pao0626 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In chapter 8, the example code for setting permissions is as follows:
We have two options:
sudo.This commit adopts the sudo method to maintain security constraints.