Skip to content

fix: optimize the implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

fix: optimize the implementation #1

merged 1 commit into from
Nov 11, 2020

Conversation

deleonio
Copy link

@deleonio deleonio commented Nov 11, 2020 •
edited
Loading

@syvb syvb merged commit 1993448 into syvb:update-virtual-modules Nov 11, 2020
@syvb
Copy link
Owner

syvb commented Nov 11, 2020

I've merged this, although note that in the future we'll probably use a different approach that doesn't require keeping around a fork of webpack-virtual-modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deleonio @syvb