Skip to content

fix: underline select padding #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: underline select padding #168

merged 1 commit into from
Oct 9, 2024

Conversation

hyunbinseo
Copy link
Contributor

@hyunbinseo hyunbinseo commented Oct 8, 2024

<select> element should have a larger right-padding to accommodate the dropdown arrow.

However, the underline themed <select> had a px-0.5 set, causing long text to show above the arrow.

  • Underline
  • Unstyled
  • Simple
  • Solid

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 6:07pm

@adamwathan
Copy link
Member

Thank you!

@adamwathan adamwathan merged commit e581f0e into tailwindlabs:main Oct 9, 2024
2 checks passed
@hyunbinseo hyunbinseo deleted the patch-1 branch October 9, 2024 01:09
@hyunbinseo
Copy link
Contributor Author

Revisiting this PR, maybe the value should be pr-10 matching other styles.

Especially since the same background-image SVG was used in all <select> elements.

select {
  background-image: url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' fill='none' viewBox='0 0 20 20'%3e%3cpath stroke='%236b7280' stroke-linecap='round' stroke-linejoin='round' stroke-width='1.5' d='M6 8l4 4 4-4'/%3e%3c/svg%3e");
  background-position: right 0.5rem center;
  background-repeat: no-repeat;
  background-size: 1.5em 1.5em;
  padding-right: 2.5rem;
  -webkit-print-color-adjust: exact;
          print-color-adjust: exact;
}

adamwathan pushed a commit that referenced this pull request Oct 14, 2024
Sorry for the dual PR. Follow up for
#168

I believe `pr-10` should be applied for consistency.
[explanation](#168 (comment))

Also, the updated `index.html` does not seems to be deployed to
production.

https://tailwindcss-forms.vercel.app/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants