Skip to content

Handle style exports condition when processing @imports #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 26, 2024
Merged

Handle style exports condition when processing @imports #934

merged 8 commits into from
Mar 26, 2024

Conversation

thecrypticace
Copy link
Contributor

If you @import "some-package" we weren't handling the style export condition. This isn't handled by postcss-import (it doesn't support reading from exports at all because the resolve package doesn't). So here we pass a custom resolve() function to handle this situation.

Fixes #933

@thecrypticace thecrypticace changed the title Resolve style exports field when processing @imports Handle style exports condition when processing @imports Mar 25, 2024
@thecrypticace thecrypticace force-pushed the fix/postcss-exports-resolve branch from e148870 to 13ec5d0 Compare March 25, 2024 18:22
@thecrypticace thecrypticace force-pushed the fix/postcss-exports-resolve branch from 629d102 to 9e86bc4 Compare March 26, 2024 14:45
@thecrypticace thecrypticace merged commit cf97d7a into master Mar 26, 2024
@thecrypticace thecrypticace deleted the fix/postcss-exports-resolve branch March 26, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait RobinMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v4] @import not following style specifier in exports
2 participants
@thecrypticace @RobinMalfait