Skip to content

Show color decorators for oklab and oklch colors #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Mar 26, 2024

Now we can display color decorators for colors using lab, lch, oklab, and oklch.

Given that these are wide-gamut color spaces the behaviors here are a bit different:

  • Color decorators display the closest sRGB approximation of the color
  • Color equivalent hex values only appear when the color is displayable within the sRGB color space
  • Color presentations / pickers are not supported. VSCode (and the language server protocol in general) does not yet support wide-gamut colors so allowing modifications and interactions in this way would be lossy.

Fixes #887

@thecrypticace thecrypticace merged commit 745c3ab into master Mar 27, 2024
@thecrypticace thecrypticace deleted the feat/oklch branch March 27, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Color previewer]: No support for oklch (DaisyUI v4)
2 participants