Skip to content

Fix symlink issues when resolving @source directives #17391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2025
Merged

Fix symlink issues when resolving @source directives #17391

merged 6 commits into from
Mar 26, 2025

Conversation

RobinMalfait
Copy link
Member

This PR fixes some issues related to symlinks when using them in the @source directive.

Fixes: #16765
Fixes: #16038

Test plan

  1. Added tests to prove this works
    • Added a recursive symlink test as well to make sure we don't hang
  2. Existing tests still pass

[ci-all]

@RobinMalfait RobinMalfait requested a review from a team as a code owner March 26, 2025 11:53
@RobinMalfait RobinMalfait enabled auto-merge (squash) March 26, 2025 12:11
@RobinMalfait RobinMalfait merged commit b0c48c3 into main Mar 26, 2025
18 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-16038 branch March 26, 2025 12:11
This was referenced Mar 26, 2025
Closed
Closed
philipp-spiess pushed a commit that referenced this pull request Mar 28, 2025
@RobinMalfait @philipp-spiess
Fix symlink issues when resolving @source directives (#17391)
4bd0b6c 
This PR fixes some issues related to symlinks when using them in the
`@source` directive.

Fixes: #16765
Fixes: #16038

## Test plan

1. Added tests to prove this works
   - Added a recursive symlink test as well to make sure we don't hang
2. Existing tests still pass


[ci-all]
@dcastil dcastil mentioned this pull request Apr 5, 2025
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecrypticace thecrypticace thecrypticace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@source directive does not glob across symlink directories @source directive not working with pnpm
2 participants
@RobinMalfait @thecrypticace