Skip to content

Add test coverage for property-specific colors #17436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 11, 2025

Conversation

scottbedard
Copy link
Contributor

@scottbedard scottbedard commented Mar 28, 2025

There are several property-specific color variables available to maintain compatibility with v3. My team and I would like to use them, but would feel more comfortable if they were formally supported by v4. This PR adds test coverage for those features.

@RobinMalfait has confirmed that these features are not intended to be removed, see conversation here →

@crswll Has opened a PR here for the related documentation

Verified

This commit was signed with the committer’s verified signature.
nirrozenbaum Nir Rozenbaum
@scottbedard scottbedard marked this pull request as ready for review March 28, 2025 17:50
@scottbedard scottbedard requested a review from a team as a code owner March 28, 2025 17:50

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Thanks for your contribution. Adding more test coverage here makes sense but there seems to be an issue with box shadows. Mind looking into it?

scottbedard and others added 6 commits April 1, 2025 10:30
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for increasing the test coverage here! Highly appreciated!

@philipp-spiess philipp-spiess merged commit 3bea760 into tailwindlabs:main Apr 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants