-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add test coverage for property-specific colors #17436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! Thanks for your contribution. Adding more test coverage here makes sense but there seems to be an issue with box shadows. Mind looking into it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for increasing the test coverage here! Highly appreciated!
There are several property-specific color variables available to maintain compatibility with v3. My team and I would like to use them, but would feel more comfortable if they were formally supported by v4. This PR adds test coverage for those features.
@RobinMalfait has confirmed that these features are not intended to be removed, see conversation here →
@crswll Has opened a PR here for the related documentation