Polyfill: Fall back to first color value when color-mix(…)
contains unresolvable var(…)
#17513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further improves the
color-mix(…)
polyfill to create a reasonable fallback if dynamic values that can not statically be resolved are used. This refers to either the use ofcurrentcolor
or any variables that are not static theme variables.Here are two examples that now generate a reasonable fallback instead of not showing any color at all:
Test plan
<p className="text-shadow-lg/50 [--my-color:red] text-shadow-(color:--my-color)">shadow test</p>
color-mix(…)
will properly show a red shadow now albeit with 100% opacity: iOS 15.5 and Chrome 110var(…)var(…)
being chained with no space by lightningcss: Chrome 111