Skip to content

Rename roman to not-italic #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Rename roman to not-italic #663

merged 1 commit into from
Feb 18, 2019

Conversation

adamwathan
Copy link
Member

I made this same change way back in v0.5.0 but had to revert it due to a bug in postcss-selector-not that made it impossible for people to use Tailwind with that plugin becuase of classes like sm:not-italic being interpreted as containing a :not pseudo-selector.

That has since been fixed, and postcss-preset-env (the library most people would be transitively depending on postcss-selector-not from) has been tagged to use the fixed version, so I think (especially for 1.0) that it is safe to finally make this change.

@adamwathan adamwathan merged commit bbcff43 into next Feb 18, 2019
@missmatsuko
Copy link

I haven't actually used oblique before, but font-style can be normal, italic, or oblique (with an optional angle). Is it weird to name it not-italic when it's also not-oblique?

@adamwathan
Copy link
Member Author

It is a little weird but we have the same issue with underline, no-underline, and line-through, where line-through affects the same property but you need to use no-underline to undo it. I can live with it, it's not the sort of thing you tweak that much responsively anyways.

@adamwathan adamwathan deleted the rename-roman branch March 8, 2019 13:37
DCzajkowski pushed a commit to DCzajkowski/tailwindcss that referenced this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants