Skip to content

[PR-23855] pack of improvements and fixes #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

en-ver
Copy link
Contributor

@en-ver en-ver commented Feb 5, 2025

1. Redirect cases extension
New case handler has been added
/path/page.html?q=1 --> /path/page/?q=1
Read nginx's default.conf comment for full list of cases

2. Navbar burger button fix
The PyData theme, which is used as the basis for the Book theme starting from v0.16, introduced the bug with the navbar burger button.
The Pydata version has been downgraded to 0.15.4
See for more details
pydata/pydata-sphinx-theme#2067

3. Add a hidden title to the main page
No H1 title on the main page caused <no title> value in title meta tag and name in navigation URL at the bottom of the second page
Fixed by adding the title but hiding it with styles

4. requirements.txt cleanup
Leftover packages clean up

The demo can be seen in bastion
https://docs.bastion.talkable.com/

Related Stories

to make it shown in meta tags and pages naviagtion (left arrow in the bottom of the next page after main) but not shown in main page
 /path/page.html?q=1
 to be redirected to
 /path/page/?q=1
@zhuravel zhuravel added the LG Looks good label Feb 5, 2025
@en-ver en-ver merged commit 1619b60 into master Feb 5, 2025
2 checks passed
@en-ver en-ver deleted the enver-PR-23855-url-redirect-improvement branch February 5, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LG Looks good
Development

Successfully merging this pull request may close these issues.

2 participants