Asynchronously declared nested tests w/ plan() w/o end() #98
+36
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
substack/tape
shares many of the same tests withisaacs/node-tap
(I assume the tests here came fromnode-tap
), I am adding a test fromnode-tap
that I wrote totape
.Recently I added (to
node-tap
) support for asynchronously declaring nested tests tonode-tap
when you've given a plan() (the plan() lets it knows to wait for asynchronously created nested test harnesses). I added this same test totape
in this pull request. No further modifications were needed totape
since this test passed right out of the box. ... Plus it never hurts to have more tests. :)Here is the PR on
node-tap
from where this test was pulled from: tapjs/tapjs#103