Skip to content

jdbc: remove the outdated tarantool sql types #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

jdbc: remove the outdated tarantool sql types #131

wants to merge 1 commit into from

Conversation

nicktorwald
Copy link

@nicktorwald nicktorwald commented Mar 11, 2019 •
edited
Loading

NUMERIC/DATE-related types were removed and BLOB type
was replaced by SCALAR in scope of new SQL type changes

fixes: #130

@nicktorwald nicktorwald added this to the JDBC MVP milestone Mar 11, 2019
@nicktorwald nicktorwald added the bug Something isn't working label Mar 11, 2019
@nicktorwald nicktorwald requested a review from Totktonada March 11, 2019 05:56
@nicktorwald nicktorwald self-assigned this Mar 11, 2019
@Totktonada Totktonada removed the jdbc label Mar 11, 2019
@Totktonada Totktonada removed this from the JDBC MVP milestone Mar 11, 2019
@Totktonada
Copy link
Member

Thanks!

Pushed as d2dfa4c (I had updated the commit message a bit, mainly to add Fixes #xxx and the link to tarantool issue).

I think it also worth to recheck #45 with recent tarantool (there is a disabled test case in tarantool-java). I have assigned it to you.

@Totktonada Totktonada closed this Mar 11, 2019
@Totktonada Totktonada deleted the nicktorwald/gh-130-broken-sql-types branch March 11, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Awaiting requested review from Totktonada

Assignees

@nicktorwald nicktorwald

Labels
bug Something isn't working jdbc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reflect recent SQL type changes
2 participants
@nicktorwald @Totktonada