Skip to content

Add basic SocketChannelProvider implementation #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add basic SocketChannelProvider implementation #144

wants to merge 1 commit into from

Conversation

akudiyar
Copy link

  • Add basic reconnecting SocketChannelProvider implementation
  • Remove strange timeout calculation logic: one timeout setting specifies any timeout between retries, the max number of retries is multiplied per socket pool for the RoundRobinSocketProvider

@Totktonada
Copy link
Member

@akudiyar It seems that PR #136 provides something like that. We need to elaborate whether the behaviour is what you want.

@nicktorwald Can you compare, please?

@nicktorwald
Copy link

nicktorwald commented Apr 1, 2019 •
edited
Loading

I think the work should be done in scope of #136 but this PR raises a question (described in the review comment) to be clarified.

@Totktonada
Copy link
Member

I would treat this PR as a request to change meaning of retries count and possibly timeout to apply them for each node when reveral ones are provided. It seems reasonable and I think it worth to implement it in a separate PR after PR #136 will land into master.

@nicktorwald What do you think?

@nicktorwald
Copy link

Agreed, the PR idea looks sensible. But this PR will be incompatible with master when the cluster issue is merged. It requires significant reworking of this PR or doing a completely new one.

@Totktonada
Copy link
Member

Let's do new one.

@Totktonada Totktonada mentioned this pull request Apr 20, 2019
Closed
@Totktonada
Copy link
Member

I described my vision in #167. We'll change it within separate PR. Alexey, thanks to pointing those aspects to us!

@Totktonada Totktonada closed this Apr 20, 2019
nicktorwald added a commit that referenced this pull request Apr 24, 2019
@nicktorwald
Apply connection timeout for each connect attempt
df85bbd 
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.

Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.

Update README doc im scope of new socket provider contract.

Closes: #167
Follows on: #144
@nicktorwald nicktorwald mentioned this pull request Apr 24, 2019
Merged
nicktorwald added a commit that referenced this pull request Apr 24, 2019
@nicktorwald
Apply connection timeout for each connect attempt
6745179 
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.

Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.

Update README doc im scope of new socket provider contract.

Closes: #167
Follows on: #144
nicktorwald added a commit that referenced this pull request Apr 24, 2019
@nicktorwald
Apply connection timeout for each connect attempt
dcf562b 
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.

Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.

Update README doc im scope of new socket provider contract.

Closes: #167
Follows on: #144
nicktorwald added a commit that referenced this pull request May 13, 2019
@nicktorwald
Apply connection timeout for each connect attempt
8084884 
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.

Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.

Update README doc im scope of new socket provider contract.

Closes: #167
Follows on: #144
nicktorwald added a commit that referenced this pull request May 14, 2019
@nicktorwald
Apply connection timeout for each connect attempt
fe6bdbb 
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.

Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.

Update README doc im scope of new socket provider contract.

Closes: #167
Follows on: #144
nicktorwald added a commit that referenced this pull request May 15, 2019
@nicktorwald
Apply connection timeout for each connection attempt
f960c18 
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.

Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.

Update README doc im scope of new socket provider contract.

Closes: #167
Follows on: #144
nicktorwald added a commit that referenced this pull request May 15, 2019
@nicktorwald
Apply connection timeout for each connection attempt
9729f0b 
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.

Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.

Update README doc im scope of new socket provider contract.

Closes: #167
Follows on: #144
Totktonada pushed a commit that referenced this pull request May 16, 2019
@nicktorwald @Totktonada
Apply connection timeout for each connection attempt
3e6b15c 
Relax a socket provider contract. Now socket provider can throw a
transient error and the client will try to obtain a socket again instead
of being closed.

Make built-in socket providers configurable. Now the client can set
retries count and connection timeout for providers.

Update README doc im scope of new socket provider contract.

Closes: #167
Follows on: #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akudiyar @Totktonada @nicktorwald