Support Connection.isValid method #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
approved these changes
Apr 16, 2019
There was a problem hiding this comment.
LGTM.
The only comment: I would clarify the commit message a bit:
Use 'SELECT 1' expression as a ping request to an underlying database.
The current implementation lacks of timeout support because it would
require at least Statement.setQueryTimeout() and Statement.cancel().
This will be implemented in the scope of #155.Closes: #75
nicktorwald
force-pushed
the
nicktorwald/gh-75-connection-is-valid
branch
from
e9272e8 to
df814c2
Compare
|
Pushed in 197d7fa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ping request to the DB using
SELECT 1expression. Timeout requiresthe implementation of at least Statement.setQueryTimeout and
Statement.cancel (see #155 ).
Closes: #75
Depends on: #155