Filter wrong formatted discovery addresses #197
Conversation
nicktorwald
force-pushed
the
nicktorwald/gh-195-discard-discovery-addr
branch
from
a911a05 to
ff10903
Compare
There was a problem hiding this comment.
Review for 'Do not use call_16 method in the tarantool client'.
I would clarify the commit message to clearly state that support of call_16 is removed.
I think it also worth to fix README re single/list result from a cluster discovery function right in this commit (because it is changed here).
src/main/java/org/tarantool/cluster/TarantoolClusterStoredFunctionDiscoverer.java
Outdated
Show resolved
Hide resolved
src/test/java/org/tarantool/cluster/ClusterServiceStoredFunctionDiscovererIT.java
Show resolved
Hide resolved
src/test/java/org/tarantool/cluster/ClusterServiceStoredFunctionDiscovererIT.java
Show resolved
Hide resolved
nicktorwald
force-pushed
the
nicktorwald/gh-195-discard-discovery-addr
branch
2 times, most recently
from
680e8de to
5313a92
Compare
There was a problem hiding this comment.
The code looks ok for me. Just several notes about commit messages.
#196 is closed in the commit re call_16 / call_17, not in 'Filter wrong formatted discovery addresses'.
'Change discovery function requirements in part of single value support' — did you mean that a non-list value is forbidden? If so, this is also actually about the commit re call_16 / call_17.
Please, fix comments and merge.
The call_16 became obsolete when tarantool-1.6 was gone. There're no reasons to continue using the old version by default. Change discovery function requirements in part of single value support. This is done to be consistent with other Tarantool connectors. Closes: #196
Instead of discarding the full list of addresses when at least one address does not match the format like host[:port] a discoverer just skips the broken address and carries on processing. Closes: #195
nicktorwald
force-pushed
the
nicktorwald/gh-195-discard-discovery-addr
branch
from
5313a92 to
5224914
Compare
Instead of discarding the full list of addresses when at least one
address does not match the format like host[:port] a discoverer just
skips this broken address and carries on processing.
Change discovery function requirements description in part of single
value support. This is done to be consistent with other Tarantool
connectors.
Closes: #195, #196