-
Notifications
You must be signed in to change notification settings - Fork 46
api: extend connect with fetch_schema
param
#271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: extend connect with fetch_schema
param
#271
Conversation
88aaa84
to
0aeaef7
Compare
So there won't be any way to use a connection for any space operations? Only calls and evals? To be honest, I don't quite get this one without tests. |
I suppose, it is.
|
0aeaef7
to
c462575
Compare
Now the connection with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR and sorry I'm a bit late (I wasn't sure that it was ready for review).
You'll also need to rebase, sorry for the inconveniences |
244e67c
to
b4472cd
Compare
While working on the task, I noticed that there is an issue in the CRUD tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! There are still some things we need to resolve
639a9d5
to
3fc3701
Compare
c57fdfb
to
eed5833
Compare
eed5833
to
b333b6f
Compare
b333b6f
to
fdc10f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! Let's fix remaining minor things and merge this one
fdc10f3
to
84b7617
Compare
Thanks for the feedback! I've made all the corrections. At the moment there is a problem with tests that fall with variable probability. At the moment, it is difficult to determine the cause, but the problem, as far as I can see, is related to the # Turning the same connection into schemafull.
if mode is not None:
for addr in con.pool.keys():
con.pool[addr].conn.update_schema(con.pool[addr].conn.schema_version) # <------
else:
con.update_schema(con.schema_version) It looks like there is a desynchronization with the transmitted |
84b7617
to
161a9c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems good, I'll wait till you resolve this flaky test issue.
f7edf6a
to
15a5655
Compare
In crud tests, if the necessary rocks dependencies are missing, an error message is now displayed. Prior to this fix, an error in importing missing models caused the tests to freez forever. Part of #205
Added support of the fetch_schema parameter, which allows to ignore schema changes on the server. Closes #219
15a5655
to
d89651e
Compare
Ping me when everything is ready |
Added support of the
fetch_schema
parameter, which allows to ignore schema changes on the server.By default, it is used
fetch_schema = True
:If the
fetch_schema
is specified asFalse
, fieldsschema_version
andschema
will no longer be present in theconnection
object:In this case, requests to the server via the
connection.update_schema
will no longer be made when there isSchemaReloadException
.Closes #219