Skip to content

Commits to increase test coverage #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 11, 2012
Merged

Conversation

apeckham
Copy link

mysql2postgres is awesome. I spent some time increasing test coverage to encourage further development and prevent regressions.

I added tests for:

  • enum conversion
  • force_truncate (which had a bug and was not being respected)
  • printing to stdout
  • datetime conversion and datetime column defaults
  • foreign keys
  • unique indexes and renamed unique indexes
  • null conversion

Thank you!

Aaron

@jcoleman
Copy link

My newest pull request includes these commits as well. Note all tests do run successfully.

@apeckham
Copy link
Author

tardate, would it be better if I submitted this to maxlapshin's branch? I'm not sure where the best place is for these changes.

@jcoleman
Copy link

maxlapshin has been rather unresponsive on a few month's worth of pull requests on his repo--it might be beneficial for someone to ask him if he would like someone else to take over managing the primary repo.

…ames because they might not be unique or might collide with table names
tardate added a commit that referenced this pull request Feb 11, 2012
Commits to increase test coverage
@tardate tardate merged commit 727d9cd into tardate:master Feb 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants