Refactor string escaping & add with/without timezone option #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amed because they match the table name
… true, TRUNCATE statements were not getting written out. increase test coverage to 91%
Use Ruby's built in String escaping to handle more cases. Explicitly handing the special \N and \. COPY command sequences. Strip null characters from the string (and issue a warning) since PostgreSQL's TEXT types don't allow those in any encoding.
tardate
added a commit
that referenced
this pull request
Feb 11, 2012
Refactor string escaping & add with/without timezone option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Ruby's built in String escaping to handle more cases. Explicitly handing the special \N and . COPY command sequences. Strip null characters from the string (and issue a warning) since PostgreSQL's TEXT types don't allow those in any encoding.
Also add option to generate timestamp/time columns DDL with or without time zones (since MySQL doesn't support that distinction, but PostgreSQL does.)