Skip to content

remove unnecessary isEndGroup check in serializer #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2022
Merged

remove unnecessary isEndGroup check in serializer #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions e2e-tests/clientcompat/src/clientcompat.pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,6 @@ export const Empty = {

readMessage: function (msg: Partial<Empty>, reader: BinaryReader): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
default: {
Expand Down Expand Up @@ -175,9 +172,6 @@ export const Req = {

readMessage: function (msg: Partial<Req>, reader: BinaryReader): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -224,9 +218,6 @@ export const Resp = {

readMessage: function (msg: Partial<Resp>, reader: BinaryReader): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -285,9 +276,6 @@ export const ClientCompatMessage = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down
18 changes: 0 additions & 18 deletions e2e-tests/test-protos/src/10/multi-service.pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,6 @@ export const InfoRequest = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
default: {
Expand Down Expand Up @@ -243,9 +240,6 @@ export const DoStuffRequest = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
default: {
Expand Down Expand Up @@ -286,9 +280,6 @@ export const InfoResponse = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -338,9 +329,6 @@ export const DoStuffResponse = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -393,9 +381,6 @@ export const VerifyRequest = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -456,9 +441,6 @@ export const VerifyResponse = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down
9 changes: 0 additions & 9 deletions e2e-tests/test-protos/src/24/long.pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ export const VeryLongNameThatCausesAnError = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -159,9 +156,6 @@ export const GetAllRequest = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
default: {
Expand Down Expand Up @@ -198,9 +192,6 @@ export const GetAllResponse = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
default: {
Expand Down
12 changes: 0 additions & 12 deletions e2e-tests/test-protos/src/34/address.pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ export const GetUserResponse = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -129,9 +126,6 @@ export const GetUserResponse = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -206,9 +200,6 @@ export const GetUserResponse = {
): void {
msg.address = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -283,9 +274,6 @@ export const AddressValue = {
reader: BinaryReader
): void {
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down
30 changes: 0 additions & 30 deletions e2e-tests/test-protos/src/7/a.pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,9 +335,6 @@ export const Foo1Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -421,9 +418,6 @@ export const Foo1Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -507,9 +501,6 @@ export const Foo2Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -593,9 +584,6 @@ export const Foo2Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -679,9 +667,6 @@ export const Foo3Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -765,9 +750,6 @@ export const Foo3Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -851,9 +833,6 @@ export const Foo4Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -937,9 +916,6 @@ export const Foo4Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -1023,9 +999,6 @@ export const Foo5Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -1109,9 +1082,6 @@ export const Foo5Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down
30 changes: 0 additions & 30 deletions e2e-tests/test-protos/src/7/b.pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,9 +335,6 @@ export const Foo1Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -421,9 +418,6 @@ export const Foo1Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -507,9 +501,6 @@ export const Foo2Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -593,9 +584,6 @@ export const Foo2Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -679,9 +667,6 @@ export const Foo3Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -765,9 +750,6 @@ export const Foo3Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -851,9 +833,6 @@ export const Foo4Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -937,9 +916,6 @@ export const Foo4Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -1023,9 +999,6 @@ export const Foo5Request = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down Expand Up @@ -1109,9 +1082,6 @@ export const Foo5Response = {
msg.d = [];
msg.e = [];
while (reader.nextField()) {
if (reader.isEndGroup()) {
break;
}
const field = reader.getFieldNumber();
switch (field) {
case 1: {
Expand Down
Loading