-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
A preview of this PR can be found at https://tc39.es/proposal-async-explicit-resource-management/pr/6. |
Can you |
This PR also cleans up a few sections of the non-async version of the proposal that I plan to backport:
|
No. |
Can you |
No, you can't do |
I like everything about this except that it has I see someone from the community has expressed the same intuition as me. (Seems fine to merge this PR as-is and continue discussing the spelling in another issue, though, since this PR establishes more than just the spelling.) |
I chose I also chose Finally, |
I disagree with that position. I don't think developers will trip over
Right - a meaning clearly inapplicable to By contrast,
As I've mentioned elsewhere, I think that the difficulty of specifying one semantics or another should basically never factor into our user-facing decisions about the language, except for things which will be encountered very rarely and which we are approximately ambivalent between - not the case here. Whatever we settle on, as long as it's implementable, as editor I am happy to find a way to write that down. |
Is there a way to provoke the github actions to keep https://tc39.es/proposal-async-explicit-resource-management/pr/6/ up to date? |
It already should be doing this. |
Thanks! (Looking again, I'm not sure why I was confused) |
Given that the actual interleaving point is no longer explicit, we do have a preference for the |
Not having given this PR a totally thorough review, it looks reasonable to me, and delivers on the promises made by parts of the README today (which is, without this, a little incoherent, as I noted in #7). I recommend that you land this patch now, as review continues, to avoid the confusion for future reviewers that I went through just now :) (A tangent, and I'm a bit late to this, but it feels kinda crazy to me that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not done a thorough review, but the changes seem to capture the output of the discussion and compromise we reached in #1.
On |
Both C# and Python heavily influenced the design of this proposal. C#'s variant uses Every instance of
As a result, Every instance of The async version of the
|
If necessary, we can bikeshed the use of |
This updates the proposal specification text to reflect the tentative outcome of #1:
using
isusing await x = y
.using await
willawait
when control flow exits the block if anyusing await
statements are evaluated, even if the resource wasnull
orundefined
:Fixes #1