Skip to content

Normative: Change to Min/Max Fraction Digits #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Normative: Change to Min/Max Fraction Digits #145

wants to merge 6 commits into from

Conversation

sffc
Copy link
Collaborator

@sffc sffc commented Mar 31, 2023

Fixes #144

sffc
sffc commented Mar 31, 2023
View reviewed changes
@ryzokuken ryzokuken added Meeting Discussion Need to be discussed in one of the upcoming meetings normative labels Apr 3, 2023
FrankYFTang
FrankYFTang reviewed Apr 4, 2023
View reviewed changes
spec.emu
@@ -314,8 +314,8 @@ contributors: Ujjwal Sharma, Younies Mahmoud
1. Set _value_ to _value_ + _duration_.[[Microseconds]] / 10<sup>3</sup> + _duration_.[[Nanoseconds]] / 10<sup>6</sup>.
1. Else,
1. Set _value_ to _value_ + _duration_.[[Nanoseconds]] / 10<sup>3</sup>.
1. Perform ! CreateDataPropertyOrThrow(_nfOpts_, *"maximumFractionDigits"*, _durationFormat_.[[FractionalDigits]]).
1. Perform ! CreateDataPropertyOrThrow(_nfOpts_, *"minimumFractionDigits"*, _durationFormat_.[[FractionalDigits]]).
1. Perform ! CreateDataPropertyOrThrow(_nfOpts_, *"maximumFractionDigits"*, _durationFormat_.[[MinimumFractionDigits]]).
Copy link
Collaborator

@FrankYFTang FrankYFTang Apr 4, 2023 •
edited by ryzokuken
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong, you need to swap the value

It should NOT be
Perform ! CreateDataPropertyOrThrow(_nfOpts_, *"maximumFractionDigits"*, _durationFormat_.[[MinimumFractionDigits]]).
but
Perform ! CreateDataPropertyOrThrow(_nfOpts_, *"minimumFractionDigits"*, _durationFormat_.[[MinimumFractionDigits]]).

same issue in the next line

ryzokuken
ryzokuken approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for @FrankYFTang's comment. Let's discuss this on thursday.

@sffc sffc added the invalid This doesn't seem right label Apr 6, 2023
@ryzokuken
Copy link
Member

@sffc why is this labeled "invalid"? I thought this change has TG2 consensus and we just need TG1 consensus to proceed.

@ryzokuken ryzokuken added consensus We reached a consensus in a discussion meeting, through email or the issue discussion needs-tg1 and removed Meeting Discussion Need to be discussed in one of the upcoming meetings labels May 4, 2023
@ryzokuken
Copy link
Member

2023-05-17: TG1 consensus.

@sffc
Copy link
Collaborator Author

sffc commented May 19, 2023

@sffc why is this labeled "invalid"? I thought this change has TG2 consensus and we just need TG1 consensus to proceed.

TG2 did not approve the PR in its current state; it would like to see an updated PR, as documented here:

#144 (comment)

@sffc sffc closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYFTang FrankYFTang FrankYFTang left review comments

@ryzokuken ryzokuken ryzokuken approved these changes

Assignees
No one assigned
Labels
consensus We reached a consensus in a discussion meeting, through email or the issue discussion invalid This doesn't seem right normative
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default digital number format to minFrac=0, maxFrac=9
3 participants
@sffc @ryzokuken @FrankYFTang