-
Notifications
You must be signed in to change notification settings - Fork 18
Normative: Revert to previous behaviour by setting fallback value for fractionalDigits to *undefined* #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Two issues:
|
Intl.DurationFormat.prototype.resolvedOptions currently asserts that all internal slots have a non-undefined value. This is no longer true if I guess an undefined |
I also wonder if the entries in Resolved Options of DurationFormat Instances should be reordered if an undefined |
e9588ca
to
b45c6ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was also the suggestion of reordering the resolvedOptions
, but I think it's something we can build consensus on this evening.
This PR reach TC39 consensus in July 12, 2023 |
Thanks for the update @FrankYFTang! I'll rebase and merge later this week. |
… to previous behaviour
…ged table in resolvedOptions to put optional FractionalDigits last and non-optional NumberingSystem first, change to pass 0/9 rather than undefined/undefined into Intl.NumberFormat for minimumFractionDigits/maximumFractionDigits
…ctionalDigits]] potentially being *undefined*
3ffc15a
to
e4774b0
Compare
Could we add some test to test262 to validate the change of this PR? |
@sffc @ben-allen @ryzokuken @ben-allen this PR is already merged to the trunk, you merge your restoration into your branch of this PR after the merging which will not fix the trunk. The landing of this PR seems very very troublesome . it include part which we didn't discuss The landing of this PR includes 4 commits according to df63a06 32950ea I beleve our edtior should revert that part of the change (the order of numberingSystem in resolvedOption should not be on the top ASAP since that was a technical error for merging something we never agree upon. If we in deed want to reoder that. That need a Normative PR to be discuss in TG2 and also TG1. |
restore Resolved Options table to ordering before PR #150 merged
Fix #149 Fix #144