This repository was archived by the owner on Jan 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
Normative: Disallow binding patterns of arrays or objects #50
Merged
sebmarkbage
merged 2 commits into
tc39:master
from
littledan:disallow-rest-destructuring
Jun 15, 2017
Merged
Normative: Disallow binding patterns of arrays or objects #50
sebmarkbage
merged 2 commits into
tc39:master
from
littledan:disallow-rest-destructuring
Jun 15, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the consensus recorded in the minutes for the May 2017 TC39 meeting, following bug tc39#43
Sorry, I don't remember what the @adamk's issue with this approach was (and it seems to have been missed in the notes). Anyone else? |
I am not involved in this project. You have the wrong user. |
Sorry, that should be @ajklein |
@sebmarkbage See the thread between Saam and myself starting at #43 (comment) for more details. |
Thanks. I'll follow up on that thread. |
I'll merge this PR since that was the last recorded consensus. We can reopen next meeting but my counter argument is here: #43 (comment) |
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Jul 16, 2017
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Jul 16, 2017
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
rwaldron
pushed a commit
to jshint/jshint
that referenced
this pull request
Jul 18, 2017
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Oct 29, 2017
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
adrianheine
added a commit
to adrianheine/acorn5-object-spread
that referenced
this pull request
Nov 4, 2017
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Jan 16, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Feb 18, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Feb 18, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Feb 18, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Feb 18, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jshint/jshint
that referenced
this pull request
Mar 19, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jshint/jshint
that referenced
this pull request
Apr 22, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jshint/jshint
that referenced
this pull request
Apr 22, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Aug 5, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Nov 20, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jshint/jshint
that referenced
this pull request
Dec 23, 2018
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Jan 1, 2019
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
jugglinmike
added a commit
to jugglinmike/jshint
that referenced
this pull request
Feb 10, 2019
The latest version of the proposal disallows BindingPattern as the right-hand side of a "rest" property. tc39/proposal-object-rest-spread#50 http://tc39.github.io/tc39-notes/2017-05_may-23.html#16ih-why-allow-bindingpattern-for-bindingrestparameter-for-object-rest-maybe-we-should-just-allow-identifiers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the consensus recorded in the minutes for the May 2017 TC39
meeting, following bug #43 .
However, @adamk raised some other points (which were brought up in the meeting) about this result; maybe it's not the right approach. I'm just uploading this patch so we can have a little more concreteness in the discussion.
The PR also switches some of the spec text to use grammardown instead of explicit tags that grammardown produces.
cc @gsathya @caiolima @sebmarkbage @saambarati @anba