This repository was archived by the owner on Apr 15, 2025. It is now read-only.
Add performance expectations #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Sep 20, 2019
| @@ -368,6 +383,19 @@ weakMap.set(record, true); | |||
|
|
|||
| # FAQ | |||
|
|
|||
| ## What are the performance expectations of those Data Structures? | |||
|
|
|||
| This proposal in itself does not put any performance guarantees and does not require specific optimizations on the implementers. It is however built in a way that some performance optimizations can be done in most cases if implementers choose to do so. | |||
There was a problem hiding this comment.
Map and Set impose specific requirements on implementations - namely, that retrieval must be sublinear as the size of the collection increases - why not do the same here?
There was a problem hiding this comment.
This is more like strings. it's not really possible to guarantee both constant time concatenation and indexing at once, but implementations try to make it kind of work anyway. We should explain this explicitly. This could also be a good place to paste the text I wrote in an issue about this topic.
There was a problem hiding this comment.
just pasted the text you wrote, I just had to retrieve it
rricard
force-pushed
the
optimization-points
branch
from
b4ce11c to
3a59a9b
Compare
|
@littledan I just copied your writeup from #2 (comment) in the PR |
littledan
approved these changes
Sep 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.