-
-
Notifications
You must be signed in to change notification settings - Fork 1
release: v2.5.0 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v2.5.0 #73
Conversation
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage ? 99.14%
=======================================
Files ? 7
Lines ? 468
Branches ? 84
=======================================
Hits ? 464
Misses ? 4
Partials ? 0 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This release contained a breaking change related to ESM; it breaks in node 16 and 18 (at least). See https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/runs/7013732772?check_suite_focus=true for details. This is also filed as DavidWells/markdown-magic#62 |
"main": "build/index.js", | ||
"types": "build/index.d.ts", | ||
"type": "module", | ||
"exports": "./dist/index.mjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specifically, adding "exports" is ALWAYS a breaking change, and this particular form makes the package ESM-only. This part of v2.5 must be reverted, and published as a v2.5.1.
(Note that "exports" replaces main
, it doesn't work with it in concert)
Changes
Base PullRequest
default branch (https://github.com/technote-space/doctoc/tree/master)
Command results
Details:
add path
cli.js -u --packageFile package.json
yarn install
yarn install v1.22.17 [1/4] Resolving packages... [2/4] Fetching packages... [3/4] Linking dependencies... [4/4] Building fresh packages... success Saved lockfile. Done in 11.95s.
yarn upgrade
yarn audit
yarn audit v1.22.17 0 vulnerabilities found - Packages audited: 615 Done in 0.66s.
Changed files
Changed 2 files: