Skip to content

Support signoff commit #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yu-iskw opened this issue Jul 6, 2022 · 1 comment · Fixed by #370
Closed

Support signoff commit #360

yu-iskw opened this issue Jul 6, 2022 · 1 comment · Fixed by #370
Assignees

Comments

@yu-iskw
Copy link

yu-iskw commented Jul 6, 2022

Please describe your suggestion: 提案の概要

Thank you for the great action.

We use the DCO app so that we accept only sign-off commits. When we manually commit changes, git commit --signoff enables us to create a sign-off commit. Whereas, when we create a commit with toc-generator, actions by the DCO app are always failed due to the lack of sign-off.

https://github.com/apps/dco

Describe the solution you'd like: 考えうる解決方法

I would like to add an inputs of the actions, say about signoff. If signoff is true, toc-generator create and push a sign-off commit.

For instance, the peter-evans/create-pull-request option offers the signoff input. We can control if a commit gets sign-off or not with the input.

Describe alternatives you've considered: 考えうる代替案

I don't have any alternative idea.

Additional context: 補足

image

@welcome
Copy link

welcome bot commented Jul 6, 2022

🙌 Thanks for opening your first issue here! Be sure to follow the issue template!

@github-actions github-actions bot added the Status: In Progress Tracking issues with work in progress label Dec 9, 2022
technote-space added a commit that referenced this issue Dec 10, 2022
feat: signoff オプションを追加
@github-actions github-actions bot mentioned this issue Dec 10, 2022
2 tasks
@github-actions github-actions bot removed the Status: In Progress Tracking issues with work in progress label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants