Skip to content

Commit 497bc61

Browse files
committed
docs: fix wrong entry in development documentation
Change the docker registry entry for KO to "localhost:5000". The former entry "kind.local" lead to an error when deploying the local pipeline build. Fix a broken link in the testing documentation and remove a leftover comment from the makefile which was targeted to a non existing configuration. Issue #8660 Issue #8486 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
1 parent a8a8c81 commit 497bc61

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

DEVELOPMENT.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ The recommended minimum development configuration is:
303303
4. Configure [ko](https://kind.sigs.k8s.io/):
304304
305305
```sh
306-
$ export KO_DOCKER_REPO="kind.local"
306+
$ export KO_DOCKER_REPO="localhost:5000"
307307
$ export KIND_CLUSTER_NAME="kind" # only needed if you used a custom name in the previous step
308308
```
309309

Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ TESTPKGS = $(shell env GO111MODULE=on $(GO) list -f \
99
BIN = $(CURDIR)/.bin
1010
WOKE ?= go run -modfile go.mod github.com/get-woke/woke
1111

12-
# Get golangci_version from tools/go.mod
1312
GOLANGCI_VERSION := $(shell yq '.jobs.linting.steps[] | select(.name == "golangci-lint") | .with.version' .github/workflows/ci.yaml)
1413
WOKE_VERSION = v0.19.0
1514

test/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ via the sections for `tektoncd/pipeline`.
410410
411411
The presubmit integration tests entrypoint will run:
412412
413-
- [The integration tests](#integration-tests)
413+
- [The integration tests](#end-to-end-tests)
414414
- A test of [our example CRDs](../examples/README.md#testing-the-examples)
415415
416416
When run using Prow, integration tests will try to get a new cluster using

0 commit comments

Comments
 (0)