Migrate golangci-lint to a container for local run
#8486
Assignees
Labels
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
kind/feature
Categorizes issue or PR as related to a new feature.
Comments
vdemeester
added
kind/feature
|
Hey @vdemeester thanks for raising this issue. I would like to tackle this issue. |
|
/assign @malinjawi |
|
Hi @vdemeester, hi @malinjawi! It looks like this issue can be closed. It was done by those PRs #8577, #8594. The only thing left is to remove this comment in the Makefile 😃 . I will open a small PR with corrections in the documentation and will remove this line also. |
Merged
8 tasks
twoGiants
added a commit
to twoGiants/tekton-pipeline
that referenced
this issue
Mar 24, 2025
Change the docker registry entry for KO to "localhost:5000". The former entry "kind.local" lead to an error when deploying the local pipeline build. Fix a broken link in the testing documentation and remove a leftover comment from the makefile which was targeted to a non existing configuration. Issue tektoncd#8660 Issue tektoncd#8486 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants
added a commit
to twoGiants/tekton-pipeline
that referenced
this issue
Mar 24, 2025
Change the docker registry entry for KO to `localhost:5000`. The former entry `kind.local` lead to an error when deploying the local pipeline build. Fix a broken link in the testing documentation and remove a leftover comment from the makefile which was targeted to a non existing configuration. Add optional installation recommendation for `yamllint` so that it can be used when running `pre-commit` locally otherwise it will show a `Failed` message when linting yaml files. Issue tektoncd#8660 Issue tektoncd#8486 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
|
Hi @vdemeester! The PR #8661 removes the comment. I think this issue can be closed. I added the "Closes #..." to my PR. |
tekton-robot
pushed a commit
that referenced
this issue
Mar 24, 2025
Change the docker registry entry for KO to `localhost:5000`. The former entry `kind.local` lead to an error when deploying the local pipeline build. Fix a broken link in the testing documentation and remove a leftover comment from the makefile which was targeted to a non existing configuration. Add optional installation recommendation for `yamllint` so that it can be used when running `pre-commit` locally otherwise it will show a `Failed` message when linting yaml files. Issue #8660 Issue #8486 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that we have a workflow, we should migrate the way user can run
golangci-lint.Today, we use
tools/go.modto specify the version, but it is already specified in the workflow.The idea would be the following:
golangci-lintimport intoolsMakefiletarget that runs a containers (usingdockerorpodman) that runs the version specified in workflow and use that for thegolangci/golangci-lint:{version}tag.The text was updated successfully, but these errors were encountered: