Skip to content

Refactor Steps and Sidecars to container_validation #7442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeromeJu opened this issue Nov 30, 2023 · 10 comments · Fixed by #8685 · May be fixed by #7538
Closed

Refactor Steps and Sidecars to container_validation #7442

JeromeJu opened this issue Nov 30, 2023 · 10 comments · Fixed by #8685 · May be fixed by #7538
Assignees
@twoGiants @abhayporwals
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Nov 30, 2023 •
edited
Loading

Now that we have container_validations, we shall move the Sidecars and Steps validation which are previously under task_validation to this file since they are more tied with container types rather than Task types.

/kind cleanup
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 30, 2023
@JeromeJu
Copy link
Member Author

/good-first-issue

@tekton-robot
Copy link
Collaborator

@JeromeJu:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 30, 2023
@abhayporwals
Copy link

Hey, @JeromeJu! I would like to work on this.
Kindly tell me a little bit more about that.

@JeromeJu
Copy link
Member Author

JeromeJu commented Dec 1, 2023

Hey, @JeromeJu! I would like to work on this. Kindly tell me a little bit more about that.

Thanks @professorabhay . I've updated the issue description to be more detailed with links to the changes you might need to make. In general this is to move the validation of struct Step to the file container_validation. No functional changes would be included.

@abhayporwals abhayporwals mentioned this issue Dec 2, 2023
Closed
@dhruval254
Copy link

hey , can i open pr for this ?

@JeromeJu
Copy link
Member Author

hey , can i open pr for this ?

Please feel free to do so. You can also assign me as the reviewer once you put up a PR.

@dhruval254
Copy link

gatcha

@dhruval254
Copy link

dhruval254 commented Dec 28, 2023 •
edited
Loading

and can you help a little with Sets.string and Sets.byte issue ?

#7374

@Dhruval7878 Dhruval7878 mentioned this issue Dec 28, 2023
Open
7 tasks
@kaushal0615
Copy link

@professorabhay are you still working on this issue?
if not I want to work on this issue.

@twoGiants
Copy link
Contributor

Hi @JeromeJu ! It looks like not much is happening here, I will take over this one.

/assign

twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 5, 2025
@twoGiants
cleanup: move step and sidecar validation
da8bd5f 
Move step and sidecar validation functions with their call chain to
container_validation.go and fix small typos.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 5, 2025
@twoGiants
cleanup: move step and sidecar validation
d8104b6 
Move step and sidecar validation functions with their call chain to
container_validation.go and fix small typos.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
@twoGiants twoGiants mentioned this issue Apr 5, 2025
Merged
8 tasks
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 9, 2025
@twoGiants
cleanup: move step and sidecar validation
2f83d73 
Move step and sidecar validation functions with their call chain to
container_validation.go and fix small typos.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 12, 2025
@twoGiants
cleanup: move step and sidecar validation
71aaff7 
Move step and sidecar validation functions with their call chain to
container_validation.go and fix small typos.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 12, 2025
@twoGiants
cleanup: move step and sidecar validation
a7e984e 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
@twoGiants twoGiants mentioned this issue Apr 13, 2025
Open
25 tasks
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 14, 2025
@twoGiants
cleanup: move step and sidecar validation
03e37f6 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 16, 2025
@twoGiants
cleanup: move step and sidecar validation
ce9363f 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 18, 2025
@twoGiants
cleanup: move step and sidecar validation
2819e85 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 19, 2025
@twoGiants
cleanup: move step and sidecar validation
5b311e9 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 19, 2025
@twoGiants
cleanup: move step and sidecar validation
c1b9782 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 22, 2025
@twoGiants
cleanup: move step and sidecar validation
f61d4a6 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants added a commit to twoGiants/tekton-pipeline that referenced this issue Apr 30, 2025
@twoGiants
cleanup: move step and sidecar validation
1624848 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue tektoncd#7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
tekton-robot pushed a commit that referenced this issue May 7, 2025
@twoGiants @tekton-robot
cleanup: move step and sidecar validation
58cd6e2 
Move step and sidecar validation functions with their call chain to
`container_validation.go` and fix small typos.

Create `validateSidecar` and move to `container_validation.go` to be
consistent with the `validateStep` function location. Inline
`validateSidecarName` function into `validateSidecar` to keep
consistency because the fields `sc.Image` and `sc.Script` are validated
in the caller.

Keep `validationSteps` and  `validateSidecars` in `task_validation.go`.

Issue #7442.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twoGiants twoGiants

@abhayporwals abhayporwals

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
6 participants
@twoGiants @JeromeJu @tekton-robot @dhruval254 @abhayporwals @kaushal0615