Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Picking out task_interface and pipeline_interface #5972

Closed
wants to merge 2 commits into from
Closed

[WIP] Picking out task_interface and pipeline_interface #5972

wants to merge 2 commits into from

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jan 9, 2023

Changes

This commit changes the Task Object reference logics to get prepared for potential removal and restriction on usage of the v1beta1 Task Interface as it would not be moved forward to v1.

This is drafted to first decouple the usage at the verify.go.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@JeromeJu
Change to not referencing Task Object Interface
351e13c 
This commit changes the Task Object reference logics to get prepared for potential removal
and restriction on usage of the v1beta1 Task Interface as it would not be moved forward to
v1.
@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Jan 9, 2023
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign imjasonh after the PR has been reviewed.
You can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested a review from lbernick January 9, 2023 18:26
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2023
@tekton-robot tekton-robot requested a review from wlynch January 9, 2023 18:26
@JeromeJu
Copy link
Member Author

JeromeJu commented Jan 9, 2023

/ok-to-test

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 9, 2023
@tekton-robot
Copy link
Collaborator

@JeromeJu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-unit-tests 351e13c link true /test tekton-pipeline-unit-tests
pull-tekton-pipeline-integration-tests 351e13c link true /test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-alpha-integration-tests 351e13c link true /test pull-tekton-pipeline-alpha-integration-tests
pull-tekton-pipeline-build-tests 351e13c link true /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JeromeJu
Copy link
Member Author

JeromeJu commented Jan 9, 2023 •
edited
Loading

TODO:

GetClusterTask was first introduced in #312 and it should

  • remove GetClusterTask

XinruZhang
XinruZhang reviewed Jan 10, 2023
View reviewed changes
pkg/trustedresources/verify.go
@@ -41,7 +41,7 @@ const (

// VerifyTask verifies the signature and public key against task.
// source is from ConfigSource.URI, which will be used to match policy patterns. k8s is used to fetch secret from cluster
func VerifyTask(ctx context.Context, taskObj v1beta1.TaskObject, k8s kubernetes.Interface, source string, policies []*v1alpha1.VerificationPolicy) error {
func VerifyTask(ctx context.Context, taskObj v1beta1.Task, k8s kubernetes.Interface, source string, policies []*v1alpha1.VerificationPolicy) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use pointer here? -- *v1beta1.Task

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 10, 2023
@JeromeJu JeromeJu changed the title Change to not referencing Task Object Interface [WIP] Picking out task_interface and pipeline_interface Jan 10, 2023
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2023
@tekton-robot
Copy link
Collaborator

@JeromeJu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JeromeJu JeromeJu closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XinruZhang XinruZhang XinruZhang left review comments

@lbernick lbernick Awaiting requested review from lbernick

@wlynch wlynch Awaiting requested review from wlynch

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/misc Categorizes issue or PR as a miscellaneuous one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeromeJu @tekton-robot @XinruZhang