Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: configure StepAction to use conversion webhook #8644

Merged
merged 2 commits into from
Mar 13, 2025
Merged

fix: configure StepAction to use conversion webhook #8644

merged 2 commits into from
Mar 13, 2025

Conversation

devholic
Copy link
Contributor

Changes

Resolves #8643

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Mar 13, 2025
@devholic
Copy link
Contributor Author

/kind bug

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Mar 13, 2025
@tekton-robot tekton-robot requested review from abayer and jerop March 13, 2025 06:17
@devholic
Copy link
Contributor Author

/assign @JeromeJu

@waveywaves
Copy link
Member

/assign

waveywaves
waveywaves suggested changes Mar 13, 2025
View reviewed changes
config/300-crds/300-stepaction.yaml
@@ -1113,3 +1113,11 @@ spec:
- tekton
- tekton-pipelines
scope: Namespaced
conversion:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add any tests for this ?
cc @afrittoli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I checked the conversion reconciler logic, the only idea I can think of right now is to add a test in the e2e/conversion_test to verify whether the CRD's Strategy is set to Webhook. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waveywaves Could you check d5944bf ? Thx in advance :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test looks good for now based on how the reconciler in knative is checking for the webhook strategy

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2025
vdemeester
vdemeester approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@devholic
Copy link
Contributor Author

/retest

@tekton-robot
Copy link
Collaborator

@devholic: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@waveywaves
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 13, 2025
@waveywaves
Copy link
Member

/retest

1 similar comment
@vdemeester
Copy link
Member

/retest

@waveywaves
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2025
@tekton-robot tekton-robot merged commit c092c89 into tektoncd:main Mar 13, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waveywaves waveywaves waveywaves requested changes

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@jerop jerop Awaiting requested review from jerop

Assignees

@waveywaves waveywaves

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhook controller reports StepActions not configured for webhook conversion
5 participants
@devholic @waveywaves @tekton-robot @vdemeester @JeromeJu